Your message dated Sun, 14 Jan 2024 17:49:54 +0000
with message-id <[email protected]>
and subject line Bug#1060257: fixed in libraw 0.21.2-1
has caused the Debian Bug report #1060257,
regarding libraw: Issue with compressed CR3 files
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1060257: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060257
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libraw
Version: 0.21.1-7
Severity: normal
Tags: upstream patch
Hi,
the libraw git repository has a fix for compressed CR3 files. The fix can be
found here:
https://github.com/LibRaw/LibRaw/commit/e231b01a49ce37d2add75e2a8f7ece5602f00457
The issue can be found here:
https://github.com/LibRaw/LibRaw/issues/624
It would be nice if you can include this patch into the 0.21.2 package.
Regards,
Tino
-- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 6.6.10 (SMP w/12 CPU threads; PREEMPT)
Kernel taint flags: TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
commit e231b01a49ce37d2add75e2a8f7ece5602f00457
Author: Alex Tutubalin <[email protected]>
Date: Thu Jan 4 15:36:38 2024 +0300
CR3-Qstep table: avoid wrong 64-bit code generation
diff --git a/src/decoders/crx.cpp b/src/decoders/crx.cpp
index 30a70205..0289c075 100644
--- a/src/decoders/crx.cpp
+++ b/src/decoders/crx.cpp
@@ -2032,7 +2032,7 @@ int crxMakeQStep(CrxImage *img, CrxTile *tile, int32_t
*qpTable, uint32_t /*tota
// not sure about this nonsense - why is it not just avg like with 2
levels?
quantVal = ((quantVal < 0) * 3 + quantVal) >> 2;
if (quantVal / 6 >= 6)
- *qStepTbl = q_step_tbl[quantVal % 6] * (1 << (quantVal / 6 + 26));
+ *qStepTbl = q_step_tbl[quantVal % 6] << ((quantVal / 6 - 6 ) & 0x1f);
else
*qStepTbl = q_step_tbl[quantVal % 6] >> (6 - quantVal / 6);
}
@@ -2052,7 +2052,7 @@ int crxMakeQStep(CrxImage *img, CrxTile *tile, int32_t
*qpTable, uint32_t /*tota
{
int32_t quantVal = (qpTable[row0Idx++] + qpTable[row1Idx++]) / 2;
if (quantVal / 6 >= 6)
- *qStepTbl = q_step_tbl[quantVal % 6] * (1 << (quantVal / 6 + 26));
+ *qStepTbl = q_step_tbl[quantVal % 6] << ((quantVal / 6 - 6) & 0x1f);
else
*qStepTbl = q_step_tbl[quantVal % 6] >> (6 - quantVal / 6);
}
@@ -2066,7 +2066,7 @@ int crxMakeQStep(CrxImage *img, CrxTile *tile, int32_t
*qpTable, uint32_t /*tota
for (int qpRow = 0; qpRow < qpHeight; ++qpRow)
for (int qpCol = 0; qpCol < qpWidth; ++qpCol, ++qStepTbl, ++qpTable)
if (*qpTable / 6 >= 6)
- *qStepTbl = q_step_tbl[*qpTable % 6] * (1 << (*qpTable / 6 + 26));
+ *qStepTbl = q_step_tbl[*qpTable % 6] << ((*qpTable / 6 - 6) & 0x1f);
else
*qStepTbl = q_step_tbl[*qpTable % 6] >> (6 - *qpTable / 6);
--- End Message ---
--- Begin Message ---
Source: libraw
Source-Version: 0.21.2-1
Done: Matteo F. Vescovi <[email protected]>
We believe that the bug you reported is fixed in the latest version of
libraw, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Matteo F. Vescovi <[email protected]> (supplier of updated libraw package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 14 Jan 2024 18:24:49 +0100
Source: libraw
Architecture: source
Version: 0.21.2-1
Distribution: unstable
Urgency: medium
Maintainer: Debian PhotoTools Maintainers
<[email protected]>
Changed-By: Matteo F. Vescovi <[email protected]>
Closes: 1060257
Changes:
libraw (0.21.2-1) unstable; urgency=medium
.
* New upstream release
* debian/patches/: patchset updated
- Old patches dropped (merged upstream)
- 0001-CR3-Qstep-table-avoid-wrong-64-bit-code-generation.patch added
(Closes: #1060257)
Checksums-Sha1:
e7fe157f60782445afc008c07d05202497be35b4 2339 libraw_0.21.2-1.dsc
7a2245b40d818c181b6b54497015638927560197 565383 libraw_0.21.2.orig.tar.gz
291840533e24bd4cfbe7215544a463d7ecf18c0c 24276 libraw_0.21.2-1.debian.tar.xz
9f566e529a14a693b7de08ef2abb76c96abf954b 6107 libraw_0.21.2-1_source.buildinfo
Checksums-Sha256:
877de29cdbf68c5f07772c542536571acd3f1a3ce5e6b056d33fc8ec064fff9b 2339
libraw_0.21.2-1.dsc
7ac056e0d9e814d808f6973a950bbf45e71b53283eed07a7ea87117a6c0ced96 565383
libraw_0.21.2.orig.tar.gz
166d549d694c597a1869030bea15ec7276e90cfeb8cb70e537e0ef69b694f56d 24276
libraw_0.21.2-1.debian.tar.xz
897220eb4ed462988da8fac97c65a36efe1dadb39194173201c0f7424448e2be 6107
libraw_0.21.2-1_source.buildinfo
Files:
ae3f2dbd770e7c5422c4fe04cf7413e3 2339 libs optional libraw_0.21.2-1.dsc
fa963b68469a03f7f11f78d770eb9f33 565383 libs optional libraw_0.21.2.orig.tar.gz
03a9ae5801e210a605657584dd0e8936 24276 libs optional
libraw_0.21.2-1.debian.tar.xz
03c24564ad014b943bfd0c11d8204564 6107 libs optional
libraw_0.21.2-1_source.buildinfo
-----BEGIN PGP SIGNATURE-----
Comment: Debian powered!
iQKTBAEBCgB9FiEE890J+NqH0d9QRsmbBhL0lE7NzVoFAmWkGPVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEYz
REQwOUY4REE4N0QxREY1MDQ2Qzk5QjA2MTJGNDk0NEVDRENENUEACgkQBhL0lE7N
zVqY1Q//dYmJDUSV91LBVeONnDXUXBbVn7+r6xQjlvtf7rOdK3ojXpyxNGB8GjVj
UzVboMTsx69W+mZmvjb2v32GBZnCqX3Htnjum8DrvOLj6u8LT1uB8IkR01z3YNBI
m6CxAXurQ1h/wCj/m91M7JpPnwhM932AqhuROHJg6zXfI8jeO/ncPaiwsj7yW8D/
phcCb06AgsQcTvjAfrEhMtTzCMyq464OCSAA3QdN8idybeBqmFcqCXE0TW5aO4Of
U2FzT84LfctNVe0LwpG/cquwPbHes9iqRtQxfy3OgiJVKNpylTZz81tBDhTfipzx
BQzqhy/SaDajJkHW02rMgbZziMmGwsCtI2g+XC6X8buLDRJpF5qdD6cwbKXq8yrG
FFVuWahdtJSADsCAP6XuXgH3YAyX0yXEgZGz+/TQRRAw/iwVKyk3dXXINkmYiE/S
gi4uKfsez/68k5G9QnoEqrP1eNZUis/1OQC2uhN7XthVWbQqCwjsTEJo74uJdFQ5
Gwj4hIqHkTYgB4C62vczLVOEOM3PzHByITaaQjVvrFqiYU0z/1/BMYweY1cUhkIT
xNLQbGMrkiH659B3IMfaIjC9VN3dQ2Ijio1FxKCfNNZCMG7kszNcGtFY9yplfTXd
TXfMerhNHoRwm/GFTS4pSILWqgF8Hgr02/gU53q2y7K3RoFmCJY=
=EBPe
-----END PGP SIGNATURE-----
--- End Message ---