Your message dated Sat, 12 Sep 2009 10:41:02 +0200
with message-id <20090912084102.gq6...@chough.tokkee.org>
and subject line Re: [Pkg-phototools-devel] Bug#546034: Bug#546034: pfstools:
FTBFS with gcc 4.4 in pfspanoramic.cpp
has caused the Debian Bug report #546034,
regarding pfstools: FTBFS with gcc 4.4 in pfspanoramic.cpp
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
546034: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=546034
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: pfstools
Version: 1.8.1-1
Severity: important
Justification: fails to build from source
Hi,
When trying to build pfstool with gcc 4.4 (in Ubuntu), I'm getting the following
error:
i486-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I../.. -I./../pfs -O3 -Wall -MT
pfspanoramic.o -MD -MP -MF .deps/pfspanoramic.Tpo -c -o pfspanoramic.o
pfspanoramic.cpp
pfspanoramic.cpp: In member function 'Vector3D Vector3D::rotateX(double)':
pfspanoramic.cpp:108: warning: no return statement in function returning
non-void
pfspanoramic.cpp: In member function 'Vector3D Vector3D::rotateY(double)':
pfspanoramic.cpp:122: warning: no return statement in function returning
non-void
pfspanoramic.cpp: In member function 'Vector3D Vector3D::rotateZ(double)':
pfspanoramic.cpp:136: warning: no return statement in function returning
non-void
pfspanoramic.cpp: In static member function 'static Projection*
ProjectionFactory::getProjection(const char*)':
pfspanoramic.cpp:198: error: invalid conversion from 'const char*' to 'char*'
pfspanoramic.cpp:198: warning: suggest parentheses around assignment used as
truth value
pfspanoramic.cpp: In member function 'virtual Vector3D*
MirrorBallProjection::uvToDirection(double, double)':
pfspanoramic.cpp:279: warning: unused variable 't'
pfspanoramic.cpp: In member function 'virtual Vector3D*
AngularProjection::uvToDirection(double, double)':
pfspanoramic.cpp:397: warning: unused variable 't'
pfspanoramic.cpp: In function 'void panoramic(int, char**)':
pfspanoramic.cpp:794: warning: unused variable 'dX'
pfspanoramic.cpp:794: warning: unused variable 'dY'
pfspanoramic.cpp:794: warning: unused variable 'dZ'
make[4]: *** [pfspanoramic.o] Error 1
make[4]: Leaving directory `/build/buildd/pfstools-1.8.1/src/filter'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/build/buildd/pfstools-1.8.1/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/build/buildd/pfstools-1.8.1'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/build/buildd/pfstools-1.8.1'
make: *** [build-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
As stated by upstream in
http://sourceforge.net/tracker/index.php?func=detail&aid=2848391&group_id=129921&atid=716245
, the line 194 should be changed to:
static Projection *getProjection(char *name)
Thanks,
Fabrice
-- System Information:
Debian Release: squeeze/sid
APT prefers karmic-updates
APT policy: (500, 'karmic-updates'), (500, 'karmic-security'), (500, 'karmic')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.28-15-generic (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash
--- End Message ---
--- Begin Message ---
Hi again,
On Fri, Sep 11, 2009 at 12:22:39AM +0200, Sebastian Harl wrote:
> On Thu, Sep 10, 2009 at 07:59:11PM +0000, Fabrice Coutadeur wrote:
> > When trying to build pfstool with gcc 4.4 (in Ubuntu), I'm getting the
> > following
> > error:
> […]
> > pfspanoramic.cpp:198: error: invalid conversion from 'const char*' to
> > 'char*'
[…]
> … anyway, if that function happens to be called with a non-const
> argument, this is still a bug. I'm thus keeping it open for now and I'll
> check if that is the case.
Uhm … I've misread that on the first try. It's not that that function is
called with a non-const argument, but rather the argument is passed
along to another function. Line 198 of pfspanoramic.cpp reads:
if(opts = strchr(name, '/'))
… where 'name' is the argument of the surrounding function:
static Projection *getProjection(const char *name)
According to POSIX (and that's how it's defined on Debian), strchr() is
defined as:
char *strchr(const char *s, int c);
So, there's nothing wrong with that. If this causes a build-failure on
Ubuntu, something's wrong with the build environment.
I'm thus closing this bug now.
Cheers,
Sebastian
--
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
--- End Message ---
_______________________________________________
Pkg-phototools-devel mailing list
Pkg-phototools-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-phototools-devel
