Your message dated Mon, 20 Apr 2020 18:04:23 +0000
with message-id <[email protected]>
and subject line Bug#955042: fixed in redmine 4.0.7-1
has caused the Debian Bug report #955042,
regarding redmine: drag and drop of attachments does not work due to used
jQuery version
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
955042: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=955042
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: redmine
Version: 4.0.4-3~bpo10+1
Steps to reproduce:
- in a browser, open the Redmine page and log in
- visit any issue in any project
- edit the issue
- drag and drop an image file into the issue form
Expected behavior:
The issue form should change its color when dragging the file
(to give a visual hint that it's a valid drop target).
After dropping the file, it should be uploaded to the Redmine server
and shown in the attached files list in the issue form.
Current behavior:
When visiting the issue page, there is an error message
(in the browser console):
Uncaught TypeError: Cannot set property 'drop' of undefined
at HTMLDocument.setupFileDrop
When dragging the file above the issue form, nothing happens.
After dropping the file, the browser will handle the file itself;
i.e. when dropping an image file, the browser will display the image.
Dependencies:
The redmine package depends on a jQuery package without a versioning:
$ apt show redmine
Package: redmine
Version: 4.0.4-3~bpo10+1
Depends: ... libjs-jquery, ...
This package is resolved to:
$ apt show libjs-jquery
Package: libjs-jquery
Version: 3.3.1~dfsg-3
There is no other version available:
$ apt list -a libjs-jquery
libjs-jquery/stable,now 3.3.1~dfsg-3 all [installed,automatic]
$ apt-cache madison libjs-jquery
libjs-jquery | 3.3.1~dfsg-3 | http://deb.debian.org/debian buster/main
amd64 Packages
Issue:
Redmine v4.0.4 uses jQuery v1.11.1 currently, see
http://svn.redmine.org/redmine/tags/4.0.4/public/javascripts/jquery-1.11.1-ui-1.11.0-ujs-4.3.1.js.
In this jQuery version something called "fixHooks" is used to copy
properties from a
JavaScript Event to jQuery's Event; see this (outdated) guide:
https://learn.jquery.com/events/event-extensions/#jquery-event-fixhooks-object
This functionality was however removed in jQuery v3.0, see this guide:
https://jquery.com/upgrade-guide/3.0/#breaking-change-jquery-event-props-and-jquery-event-fixhooks-removed
Instead the original Event can be accessed as described here:
https://api.jquery.com/category/events/event-object/
The problem is the use of "fixHooks" in this file:
http://svn.redmine.org/redmine/tags/4.0.4/public/javascripts/attachments.js
Workaround:
I applied this workaround, and it seems to resolve the issue:
File public/javascripts/attachments.js
178c178
< if ($.inArray('Files', e.dataTransfer.types) > -1) {
---
> if ($.inArray('Files', e.originalEvent.dataTransfer.types) > -1) {
180c180
< uploadAndAttachFiles(e.dataTransfer.files,
$('input:file.filedrop').first());
---
> uploadAndAttachFiles(e.originalEvent.dataTransfer.files,
$('input:file.filedrop').first());
197,198d196
<
< $.event.fixHooks.drop = { props: [ 'dataTransfer' ] };
More:
Redmine updated jQuery to v2.2.4 in v4.1.0. A Redmine contributor added
that they hope
to update jQuery to v3 or v4 in Redmine v4.2.0 or Redmine v5, see
https://redmine.org/issues/31196#note-4.
Kind regards,
Martin Gregoire
--
Martin Gregoire
Entwicklung
naymspace software GmbH & Co. KG
Krusenrotter Weg 65
24113 Kiel
Fon: +49 431 55 686 77-1
Fax: +49 431 55 686 77-9
E-Mail: [email protected]
Internet: http://www.naymspace.de
Facebook: http://www.facebook.com/naymspace
Handelsregister Kiel
HRA 9607
Persönlich haftende Gesellschafterin:
naymspace Verwaltungsgesellschaft mbH
Sitz: Kiel
Geschäftsführer: Dennis Nissen
Handelsregister Kiel
HRB 18407
Informationen zum Datenschutz und Ihren Betroffenenrechten finden Sie
hier: https://www.naymspace.de/datenverarbeitungsinformation
.............................................................................................
Der Inhalt dieser E-Mail ist ausschließlich für den bezeichneten
Adressaten bestimmt.
Wenn Sie nicht der vorgesehene Adressat dieser E-Mail oder dessen
Vertreter sein sollten,
so beachten Sie bitte, dass jede Form der Kenntnisnahme,
Veröffentlichung, Vervielfältigung
oder Weitergabe des Inhalts dieser E-Mail unzulässig ist. Wir bitten
Sie, sich in diesem Fall
mit dem Absender der E-Mail in Verbindung zu setzen.
This e-mail and any files transmitted with it are confidental and
intended solely for the use
of the individual or organization to whom they are addressed. Should you
not be the intended
addressee of this e-mail or his representative, please note that
publication, replication of the
contents by any means or further communication of the content is not
permissible. Should
you have received this e-mail in error, please notify the sender.
pEpkey.asc
Description: application/pgp-keys
--- End Message ---
--- Begin Message ---
Source: redmine
Source-Version: 4.0.7-1
Done: =?utf-8?b?TWFyYyBEZXF1w6huZXMgKER1Y2sp?= <[email protected]>
We believe that the bug you reported is fixed in the latest version of
redmine, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Marc Dequènes (Duck) <[email protected]> (supplier of updated redmine package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 21 Apr 2020 02:32:29 +0900
Source: redmine
Architecture: source
Version: 4.0.7-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Ruby Extras Maintainers
<[email protected]>
Changed-By: Marc Dequènes (Duck) <[email protected]>
Closes: 952417 955042
Changes:
redmine (4.0.7-1) unstable; urgency=medium
.
* New upstream version 4.0.7:
+ adapt/refresh patches.
* Fix import issue with tmp directory (Thanks Andre Heider) (Closes:
#952417).
* Bumped Standards-Version to 4.5.0 (no changes required).
* Minor package updates suggested by dh-make-ruby.
* Add upstream metadata.
* Switch to watch format 4.
* Add patch to fix drag-and-drop attachments with JQuery 3 (thanks
Martin Gregoire) (Closes: #955042).
* Ensure database choice match installed redmine-<db> packages.
Checksums-Sha1:
844a98e1c47cde75329be7c0b0b7baebb6cd4af1 3006 redmine_4.0.7-1.dsc
7c6fe94750be45e18546ff9e65c50826d9d2e047 1500748 redmine_4.0.7.orig.tar.xz
9d9b36260af640a01ce480aba2739762a449b730 243024 redmine_4.0.7-1.debian.tar.xz
846a5a4b83014987913a43bab0d7ddeb2cf128bb 12521 redmine_4.0.7-1_amd64.buildinfo
Checksums-Sha256:
d099302358ddcafd56ee506e3a2ecd44b8ee39337f5364cc45f038aa3ad963b7 3006
redmine_4.0.7-1.dsc
822f459c87571b001098681a6f8566410ff0ee79d2bd72bab65a8ce6ab0fca57 1500748
redmine_4.0.7.orig.tar.xz
87bdadb6fe1e19e16702a68f16941974503b33c6027e343eee7a64e54355674c 243024
redmine_4.0.7-1.debian.tar.xz
29d7055c36171a7b64e0d6b2e4a67ac1a924a364dadbb81bdfe2dd4f5f2878da 12521
redmine_4.0.7-1_amd64.buildinfo
Files:
240190a9006490442b2fcd09e098a47d 3006 web optional redmine_4.0.7-1.dsc
14de133bc8459f93c65ffea919237a04 1500748 web optional redmine_4.0.7.orig.tar.xz
4727280cf24d46f967d29c88c0f0cf9a 243024 web optional
redmine_4.0.7-1.debian.tar.xz
8f1f92b99a75a00e270af56dce6c1391 12521 web optional
redmine_4.0.7-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEcpcqg+UmRT3yiF+BVen596wcRD8FAl6d3r4ACgkQVen596wc
RD/1BQ/8CzRZ8Ul2WC38fdlC6FY9r7qe6IF+IYMHWIFQlznxQK/NWz1AcyEdL5pd
GnIHbe9TdOx1V5HBwb3XYXSbI5Y1tuge6faM0Znl8K7FZEjkzhjqCJJQCb2xFqIc
6bplv6zvhfyooDU3QzdrbnUaNDHtTXK36j0v71LrXOPLu8d07hmK1FpwY98ho1f0
PSrR0FpSySRONjrGJz6ePK1ezyYz9/e7/e2FqgymxclnEBfYVCJq+x0s01sQu4Wh
/+clkKprQPrJ0wADFRoqmYnmYJtD4NL5HB0tk7Y1IDBnpjL92Ob4OKBVkMsMhYxZ
MrrqmEU+mTMmvuivx1qibop094h30gARdWBbSPh0eygoVrsSpn7HqaVmyhbZFknF
1xOrHEe2B/y6ildpKXjqhcSaJVoGj4epvS/b5/FjsRtaU7sjyx45UNdB4bXCeuRl
1qnsWwXMyVmVpbGrVbkHisy3HFA0C/sBU1pWF4I3QM1yW1yufpYxtCcJJy2kNNVB
TxU1GIkAdvsNe4eOeNfXAg9BixILP/3AIDbXgt9kTrwjKDMnioTOdVcap4/nDcYy
4maqayq+kQPz5bDU2JuhM2Aus+pKQxuWqxoh8MT62B7t8zVbwK9wbV0E4FRZJZwC
AZmv0NrirM9SDSLeEzHuacjsepb59Mr9U1SB7FHKW7hJE8ZWswQ=
=NI9g
-----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________
Pkg-ruby-extras-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers
