On 6/19/15, Dmitry Smirnov <only...@debian.org> wrote: > I took liberty to commit native systemd service to unicorn repository.
Thanks! I hope it works properly (I can't test as I'm not a systemd user). But I have several comments regarding your changes: * You have removed "CONFIGURED" variable, that's not good because unicorn may be installed as a dependency for Rainbows (or any other unicorn-based server) and in this case it sh'ld not be started (of course user can disable it with update-rc.d but it's not a good idea). So I'll return it back. * I want to move transparent upgrade code from post-install hook to init-script because it may be useful not only on upgrade of unicorn package but with ruby and application upgrades as well. I hope "invoke-rc.d unicorn upgrade || invoke-rc.d unicorn restart" will be enough in case of systemd too. * "Should-Start: mysql" looks as dirty hack but it looks reasonable, I'll rather add postgres there too. Your other changes look reasonable, thanks. > I shall be happy to answer all your questions and hopefully help little more > with Unicorn maintenance, if time allows. Unicorn does not require a lot of maintenance efforts, but all that systemd stuff does. > Please let me know what you think. _______________________________________________ Pkg-ruby-extras-maintainers mailing list Pkg-ruby-extras-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-ruby-extras-maintainers