Your message dated Fri, 30 Nov 2018 14:52:37 +0000 with message-id <e1gsk9l-000igv...@fasolo.debian.org> and subject line Bug#907409: fixed in casync 2+20180321-2.1 has caused the Debian Bug report #907409, regarding casync: FTBFS with glibc 2.28, header mismatch wih new renameat2() to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 907409: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907409 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: casync Version: 2+20180321-2 Severity: normal Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu cosmic ubuntu-patch Dear maintainers, casync fails to build from source against glibc 2.28, as seen in the Ubuntu autopkgtest: [...] cc -Isrc/src@@shared@sta -Isrc -I../src -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -std=gnu99 -Wextra -Werror=undef -Werror=format=2 -Wformat-security -Wformat-nonliteral -Wlogical-op -Wmissing-include-dirs -Werror=old-style-definition -Werror=pointer-arith -Winit-self -Wdeclaration-after-statement -Wfloat-equal -Wsuggest-attribute=noreturn -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=missing-declarations -Werror=return-type -Werror=incompatible-pointer-types -Werror=shadow -Werror=int-conversion -Wstrict-prototypes -Wredundant-decls -Wmissing-noreturn -Wendif-labels -Wstrict-aliasing=2 -Wwrite-strings -Wno-unused-parameter -Wno-missing-field-initializers -Wno-unused-result -Werror=overflow -Werror=sign-compare -Wdate-time -Wnested-externs -fno-common -fdiagnostics-show-option -fno-strict-aliasing -fvisibility=hidden -fstack-protector -fstack-protector-strong -fPIE --param=ssp-buffer-size=4 -include config.h -g -O2 -fdebug-prefix-map=/tmp/autopkgtest.iBt8c8/build.W5z/src=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -MD -MQ 'src/src@@shared@sta/cacache.c.o' -MF 'src/src@@shared@sta/cacache.c.o.d' -o 'src/src@@shared@sta/cacache.c.o' -c ../src/cacache.c In file included from ../src/canametable.h:9, from ../src/calocation.h:12, from ../src/cacache.h:7, from ../src/cacache.c:9: ../src/util.h:532:19: error: static declaration of ‘renameat2’ follows non-static declaration static inline int renameat2(int oldfd, const char *oldname, int newfd, const char *newname, unsigned flags) { ^~~~~~~~~ In file included from ../src/util.h:12, from ../src/canametable.h:9, from ../src/calocation.h:12, from ../src/cacache.h:7, from ../src/cacache.c:9: /usr/include/stdio.h:164:12: note: previous declaration of ‘renameat2’ was here extern int renameat2 (int __oldfd, const char *__old, int __newfd, ^~~~~~~~~ ninja: build stopped: subcommand failed. [...] (https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-cosmic/cosmic/amd64/c/casync/20180825_081049_5b743@/log.gz) The casync build system does include a check for a system-provided renameat2() implementation, however, the new renameat2 in /usr/include/stdio.h in glibc 2.28 is guarded with __USE_GNU which means its availability is conditional on features.h selections - and while _GNU_SOURCE winds up being defined in meson.build for the actual software build, it is NOT defined while meson itself is doing feature detection. Perhaps adding -D_GNU_SOURCE to c_args would fix the build failure, but I used the larger hammer of defining it as DEB_CFLAGS_MAINT_APPEND=-D_GNU_SOURCE in debian/rules. Please consider the attached patch to fix this bug, which will become a serious bug once glibc 2.28 is uploaded to Debian. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.orgdiff -Nru casync-2+20180321/debian/rules casync-2+20180321/debian/rules --- casync-2+20180321/debian/rules 2018-05-03 06:12:33.000000000 -0700 +++ casync-2+20180321/debian/rules 2018-08-27 09:50:17.000000000 -0700 @@ -1,6 +1,7 @@ #! /usr/bin/make -f export DEB_BUILD_MAINT_OPTIONS=hardening=+all +export DEB_CFLAGS_MAINT_APPEND=-D_GNU_SOURCE export LC_ALL=C.UTF-8
--- End Message ---
--- Begin Message ---Source: casync Source-Version: 2+20180321-2.1 We believe that the bug you reported is fixed in the latest version of casync, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 907...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Adrian Bunk <b...@debian.org> (supplier of updated casync package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Fri, 30 Nov 2018 14:37:06 +0200 Source: casync Binary: casync Architecture: source Version: 2+20180321-2.1 Distribution: unstable Urgency: medium Maintainer: Debian systemd Maintainers <pkg-systemd-maintain...@lists.alioth.debian.org> Changed-By: Adrian Bunk <b...@debian.org> Description: casync - content addressable data synchronizer Closes: 907409 Changes: casync (2+20180321-2.1) unstable; urgency=medium . * Non-maintainer upload. * Add upstream fix for FTBFS with glibc 2.28. (Closes: #907409) Checksums-Sha1: 2518405b6a6b2dc9cd8ab7c7401e4cec055cc283 2262 casync_2+20180321-2.1.dsc 36bb1dbc7621f810ecdbfe7d706010882338cbe4 3516 casync_2+20180321-2.1.debian.tar.xz Checksums-Sha256: 1f349cce63531d7f9d5fbd1d178112911fea3eaf197d6f6a96ccf9b3129b5628 2262 casync_2+20180321-2.1.dsc 8ee0de723b44d04a932c6ae617cfbde9d7a4368e68a0c69c7eb2aa619983b59e 3516 casync_2+20180321-2.1.debian.tar.xz Files: 155eca3cfa5ffae2d60679a68ec26bc7 2262 utils optional casync_2+20180321-2.1.dsc 7320fb4574cd75a676c4e7c6f3546ec6 3516 utils optional casync_2+20180321-2.1.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEOvp1f6xuoR0v9F3wiNJCh6LYmLEFAlwBMVUACgkQiNJCh6LY mLFqOw/9EWpeqgm9CDLOR/8LE2oEHPbLOQJXVe7ZIxscUeV/9EO0VHzK/9OjsOUj KFS6vKbWBiDe6X8eCMnFzJl5D2GKrrx7XWesH7+BRYUi6EKn0Ob6VlOaIP4C5zvA u9Qnvy476t23B6PJrQEBAFZi88jsFpU/hG1EvEGDPwdkUr2FslmV0Ii3BZz2JnTy TLlK7HLswK9M/YI/fOJj+KPMOiPcYz//YN0EH3Zdirv5oIuErlmf7DeROR9GE88E W4wA/GTFMA4fV+TX5NI0rdowrxSXsHccv0rPTKJO7oxeXM6pLtxijoQDEfFYFwsB TtNFRxVBoCtaCvQov9aUS67ahDfieiQhOCEKF7nkMMPZZIrd4uKC7zjTbtIJFSuM xB8K+GNMLZuKHmiI9BXWlcEhZ1JVAF/hkEwv7o22oiN4TDFFhBeFiHdPC4osHzKG lWp+gruBW0AocJvTUbd0Jv5JQTBziwQ5L8biotOKEy+SBBUB4JosJuxIMR8MEfok 4WqqF/EFcQbwG4STrGsr7SNXTzLBkdATkW8NhAYIYWrmvvtnerhCidnwIYEVRlbK jK4RUKA0Wn8kAtweL4s8l9nvgkkas5ejR84R9ApuE+jLT1JZmN1fpY1ayX+wJKUu Xb3VIbvTmZ5d8arrbb6WkvQ4FIPt6ExvNtWsVwlgYkkIR4wrk4A= =CLH3 -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ Pkg-systemd-maintainers mailing list Pkg-systemd-maintainers@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
