Your message dated Thu, 04 Apr 2019 21:47:16 +0000
with message-id <e1hcaca-0007ob...@fasolo.debian.org>
and subject line Bug#916880: fixed in systemd 232-25+deb9u10
has caused the Debian Bug report #916880,
regarding Journald crashes in log_assert_failed()
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
916880: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916880
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: systemd
Version: 232-25+deb9u6
X-Debbugs-CC: cw8...@att.com


journald is crashing in log_assert_failed() when running stress tests.
Here is the stack trace:

#0  0x00007fad4a7a2fff in raise () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007fad4a7a442a in abort () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007fad4b240a42 in log_assert_failed () from 
/lib/systemd/libsystemd-shared-232.so
#3  0x00007fad4b27d1ff in journal_file_post_change () from 
/lib/systemd/libsystemd-shared-232.so
#4  0x000056369a264bec in ?? ()
#5  0x000056369a263402 in ?? ()
#6  0x000056369a263619 in ?? ()
#7  0x000056369a2605ee in ?? ()
#8  0x000056369a269640 in ?? ()
#9  0x000056369a2639df in ?? ()
#10 0x000056369a26784b in ?? ()
#11 0x00007fad4b2336e5 in ?? () from /lib/systemd/libsystemd-shared-232.so
#12 0x00007fad4b233894 in sd_event_dispatch () from 
/lib/systemd/libsystemd-shared-232.so
#13 0x00007fad4b234dd7 in sd_event_run () from 
/lib/systemd/libsystemd-shared-232.so
#14 0x000056369a25c4b3 in ?? ()
#15 0x00007fad4a7902e1 in __libc_start_main () from 
/lib/x86_64-linux-gnu/libc.so.6
#16 0x000056369a25e4ea in ?? ()

Debian version on our system is 9.6, and kernel version 4.14.86-0.

We don't see the crash with the following upstream fix for assertion failure:

commit 5b3cc0c86aeddd4615e7e28e79aa89e5b77a6507
Author: Yusuke Nojima <nojima...@gmail.com>
Date:   Sun Apr 30 02:37:53 2017 +0900

    journald: fix assertion failure on journal_file_link_data. (#5843)
    
    When some error occurs during the initialization of JournalFile,
    the JournalFile can be left without hash tables created.  When later
    trying to append an entry to that file, the assertion in
    journal_file_link_data() fails, and journald crashes.
    
    This patch fix this issue by checking *_hash_table_size in
    journal_file_verify_header().

diff --git a/src/journal/journal-file.c b/src/journal/journal-file.c
index 14cb01a60..243d5198d 100644
--- a/src/journal/journal-file.c
+++ b/src/journal/journal-file.c
@@ -613,6 +613,9 @@ static int journal_file_verify_header(JournalFile *f) {
                         return -EBUSY;
                 }
 
+                if (f->header->field_hash_table_size == 0 || 
f->header->data_hash_table_size == 0)
+                        return -EBADMSG;
+
                 /* Don't permit appending to files from the future. Because 
otherwise the realtime timestamps wouldn't
                  * be strictly ordered in the entries in the file anymore, and 
we can't have that since it breaks
                  * bisection. */

We would like to see if this upstream patch can be backported to Debian stretch 
systemd.

--- End Message ---
--- Begin Message ---
Source: systemd
Source-Version: 232-25+deb9u10

We believe that the bug you reported is fixed in the latest version of
systemd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 916...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Biebl <bi...@debian.org> (supplier of updated systemd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 10 Mar 2019 15:52:46 +0100
Source: systemd
Architecture: source
Version: 232-25+deb9u10
Distribution: stretch
Urgency: medium
Maintainer: Debian systemd Maintainers 
<pkg-systemd-maintain...@lists.alioth.debian.org>
Changed-By: Michael Biebl <bi...@debian.org>
Closes: 912005 916880 917122 918400
Changes:
 systemd (232-25+deb9u10) stretch; urgency=medium
 .
   * journald: fix assertion failure on journal_file_link_data (Closes: #916880)
   * tmpfiles: fix "e" to support shell style globs (Closes: #918400)
   * mount-util: accept that name_to_handle_at() might fail with EPERM.
     Container managers frequently block name_to_handle_at(), returning
     EACCES or EPERM when this is issued. Accept that, and simply fall back
     to fdinfo-based checks. (Closes: #917122)
   * automount: ack automount requests even when already mounted.
     Fixes a race condition in systemd which could result in automount requests
     not being serviced and processes using them to hang, causing denial of
     service. (CVE-2018-1049)
   * core: when deserializing state always use read_line(…, LONG_LINE_MAX, …)
     Fixes improper serialization on upgrade which can influence systemd
     execution environment and lead to root privilege escalation.
     (CVE-2018-15686, Closes: #912005)
Checksums-Sha1:
 0d2b66bca4f77fe241a6a86dbb5937c62309a331 4801 systemd_232-25+deb9u10.dsc
 75c8368b5743fceb3796d536d5cac6757a3365c0 221104 
systemd_232-25+deb9u10.debian.tar.xz
 423d25f95a764e175ed41459c9ed328020ea2779 9365 
systemd_232-25+deb9u10_source.buildinfo
Checksums-Sha256:
 5c91567d1243df91e12b52b7f5ce1dac203f4fea3eedd448e6eae2e014fe8667 4801 
systemd_232-25+deb9u10.dsc
 1f815ab415a62ab504084c2166f67e1b5623341ebda8dfe313146eff453df131 221104 
systemd_232-25+deb9u10.debian.tar.xz
 c4167523d962f2591538fbf61e8bf9882182e1c43c4d0cff6cd4cd600b7a4639 9365 
systemd_232-25+deb9u10_source.buildinfo
Files:
 0a3b3ce1e373a23731d5046b96f6f5c2 4801 admin optional systemd_232-25+deb9u10.dsc
 e1c3daf27ee3130b52599c9e1323809d 221104 admin optional 
systemd_232-25+deb9u10.debian.tar.xz
 6de8b6d7e1341d79ec4dc1d0db6ff4e6 9365 admin optional 
systemd_232-25+deb9u10_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEECbOsLssWnJBDRcxUauHfDWCPItwFAlyjx60ACgkQauHfDWCP
ItyOUA//TDjV84lrFKjQJhZngh3E1f98hPovRhBdoSRO7i7Dgs3XU27nmw/H/B0x
//JNoF5zZlHjwKwdDHmaHD5Y4gZJePz/m39cnXixBrQrVxyCPxXfmeT3C6DaH/gd
rhfakKfyjUR7mQAUecnyKdX/xjKg/HOdVj7Xu/KUgwVUHVJwrjI8YWOsfAVS3Xjk
QIxkBox36DVqPYcpsZVFL2eyIj/9Kzvhco4RJaRQvQQGCg7bO+5X5XlYp7A9yOC9
BUcDGTzCV2KagxkwjnZb1LABdcucbiIKE9yE/6avvbsTghLJIu3n1UahELBFW/kh
6iMKIN+p2DfRL3juDs7f4iuxP3FhIjgjJvauNX7SYR3EoZWtM6OFUZu99g+Pq2Ko
nRsVdt8lVhBF5NSOKfi7uRwqyfMR+Ffo8nOOWAzbbFIlEsfOuGD9DIR9wV4bD0jD
YhE//1smZU26jmAIy3X63s3fh5+W52k08bJqT24Dk9UjMBQWsHNk8UYDccKLgxmi
MdU+9bO18+tuFTAy56HMwKBrYrKfdIiaKMJzoyC64rB7HvZKa5l6dcmtU0IK9WIr
chffgYVO9IAp6Lo0T0QwGVMLtYYNlN3AeOQA48b7tzJ/BAjJwRZ3GnEb6QYPsz/K
ARS/3KakZOQNmXM3yE/QiyMH0w2htm7YsJo6N4dVF1CAQ3AuZHY=
=0oeB
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Pkg-systemd-maintainers mailing list
Pkg-systemd-maintainers@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-systemd-maintainers

Reply via email to