Your message dated Tue, 7 Jan 2014 17:07:57 +0100 with message-id <[email protected]> and subject line Re: [Pkg-xfce-devel] Bug#718497: lightdm-gtk-greeter: Last PAM error message not showing has caused the Debian Bug report #718497, regarding lightdm-gtk-greeter: Last PAM error message not showing to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 718497: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=718497 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: lightdm-gtk-greeter Version: 1.6.0-1 Severity: normal Tags: upstream patch Dear Maintainer, Whenever PAM fails the message: "Incorrect password, please try again" appears ignoring the real message from the PAM, which might be e.g. "access denied". This of course, is very confusing to users who thinks they've forgotten their passwords. The attached patch displays the "Incorrect password" message only if there's no other message displayed. Regards, Yair. -- System Information: Debian Release: jessie/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.9.3-aufs-mos-1 (SMP w/4 CPU cores) Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lightdm-gtk-greeter depends on: ii libc6 2.17-7 ii libcairo2 1.12.14-4 ii libgdk-pixbuf2.0-0 2.28.2-1 ii libglib2.0-0 2.36.3-3 ii libgtk-3-0 3.8.2-3 ii liblightdm-gobject-1-0 1.6.0-3 ii libx11-6 2:1.6.0-1 Versions of packages lightdm-gtk-greeter recommends: ii desktop-base 7.0.3 ii gnome-icon-theme 3.8.2-2 ii gnome-themes-standard 3.8.1-2 ii policykit-1 0.105-3 lightdm-gtk-greeter suggests no packages. -- no debconf information--- lightdm-gtk-greeter-1.6.0.orig/src/lightdm-gtk-greeter.c +++ lightdm-gtk-greeter-1.6.0/src/lightdm-gtk-greeter.c @@ -388,6 +388,12 @@ set_message_label (const gchar *text) gtk_label_set_text (message_label, text); } +static const gchar* +get_message_label () +{ + return gtk_label_get_text (message_label); +} + static void set_login_button_label (const gchar *username) { @@ -910,7 +916,8 @@ authentication_complete_cb (LightDMGreet { if (prompted) { - set_message_label (_("Incorrect password, please try again")); + if (get_message_label()[0] == 0) + set_message_label (_("Incorrect password, please try again")); start_authentication (lightdm_greeter_get_authentication_user (greeter)); } else
--- End Message ---
--- Begin Message --------BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Version: 1.7.0-1 On Thu, Aug 01, 2013 at 05:14:11PM +0300, Yair Yarom wrote: > Package: lightdm-gtk-greeter > Version: 1.6.0-1 > Severity: normal > Tags: upstream patch > > Dear Maintainer, > > Whenever PAM fails the message: "Incorrect password, please try again" > appears ignoring the real message from the PAM, which might be > e.g. "access denied". This of course, is very confusing to users who > thinks they've forgotten their passwords. > > The attached patch displays the "Incorrect password" message only if > there's no other message displayed. This is now fixed in experimental. Regards, - -- Yves-Alexis Perez -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAEBCgAGBQJSzCZZAAoJEG3bU/KmdcCl6VwH/0i2mit2fg/UHXq4mdFN1yN9 INmyaRltrAEWIFBmCL0d9xz+Q5/unbeEfaTjMDBYQLdwZcMC0u/wX2kutOWj6L4u q1AxRxh3muWj9zlUX8TNuvvdamwjXL7PjTbiBMUIg94PgJPIHT8xODRKIpFY44Yo MLBO5ZvGEa4oWVABiWdBkNfBNlrhI8eqrb50JjORByhsxrWgw/V/fPSta+Jf0Qnn SK7o+ICDXpJushFKgDpegn3Q5fyS0VBnJu6Rb9IJM6KoCTI5EUZ2z8tRDwOCKROz q+mcbW4T06GzJLhCe6KQ6zirmtpGkzyihQ1kz6WgtxHWR8y2Bcocd63IqigbFlQ= =xUbY -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ Pkg-xfce-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-xfce-devel
