addressed comment. pushed to master:
commit 659c90869a27871eda27fd730d00b0499873dae2
thanks!
Christina
On 06/28/2016 07:30 PM, Endi Sukma Dewata wrote:
On 6/28/2016 8:03 PM, Christina Fu wrote:
This patch addresses https://fedorahosted.org/pki/ticket/2389
Installation: subsystem certs could have notAfter beyond CA signing cert
in case of external or existing CA
thanks,
Christina
Just one thing, to help troubleshooting the exception should be
chained and the original exception message should be appended, for
example:
} catch (Exception e) {
throw new EProfileException(
"Unable to get CA certificate: " + e.getMessage(), e);
}
The class/method name doesn't need to be included in the exception
message since we can figure that out from the stack trace.
ACK with the above change.
_______________________________________________
Pki-devel mailing list
Pki-devel@redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel
