Looks simple and valuable to clean up a few possible error cases. Conditional ACK with one minor thing.
Maybe just check for "[KEYWORD" to catch a case where someone might leave out the closing bracket. Who knows what havoc that might have on an install. ----- Original Message ----- > From: "Matthew Harmsen" <mharm...@redhat.com> > To: "pki-devel" <pki-devel@redhat.com> > Sent: Wednesday, May 17, 2017 11:54:45 AM > Subject: [Pki-devel] [PATCH] - Correct section headings in user deployment > configuration file > > > > Please review the attached patch for: > > * Bugzilla Bug #1447144 - CA brought down during separate KRA instance > creation > > > Note that the Python method itself was tested in a standalone fashion against > various sample configuration files to make certain that the only thing > altered was an invalid section heading. > > It was run against the previously modified files noted in the bug and made > the following changes to the user deployment configuration files: > > > > # diff mlh_ca.cfg.orig mlh_ca.cfg > 24c24 > < [TOMCAT] > --- > > [Tomcat] > > # diff mlh_kra.cfg.orig mlh_kra.cfg > 31c31 > < [TOMCAT] > --- > > [Tomcat] > Application of this patch allowed the KRA to be installed successfully, and > did not shutdown the CA. > > > > > _______________________________________________ > Pki-devel mailing list > Pki-devel@redhat.com > https://www.redhat.com/mailman/listinfo/pki-devel _______________________________________________ Pki-devel mailing list Pki-devel@redhat.com https://www.redhat.com/mailman/listinfo/pki-devel