Hi Jim, thanks for taking a look.

Jim Ottaway <[EMAIL PROTECTED]> writes:

>
>> 2006-11-03 14:47:00 GMT      David D. Smith <[EMAIL PROTECTED]>      patch-3
>> 
>>     Summary:
>>       Don't use planner-goto-today in update-section because that's -maybe's 
>> job
>>     Revision:
>>       planner--dds--1.0--patch-3
>> 
>> 
>>     modified files:
>>      planner-appt.el
>
> I'm not sure about this one: one might want to update the appointments
> section while visiting a page that is not today's plan page. Does
> having planner-goto-today in planner-appt-forthcoming-update-section
> cause some bug?

You mean update the appointments schedule on a page that is not
today's page? If that's the case then exactly my point, you
shouldn't use planner-goto-today inside of update-section
because in that situation the user is calling update-section
directly. The point of -maybe is to be a hook that runs on
planner mode, this it should be the one checking if the current
page is the current day or not, that's the main thing.

And yes, it does trigger a publishing bug, it's the same cause
as the with-planner block in patch-2; loading a
half-muse-edited page and then running the hook and then
loading a new page and recursing until emacs pops.

Sorry, I'm in a rush right now so that's all I've got.

Thanks again,

>
>> 2006-11-03 14:46:01 GMT      David D. Smith <[EMAIL PROTECTED]>      patch-2
>> 
>>     Summary:
>>       Remove redundant (with-planner) block that causes self-recursion
>>     Revision:
>>       planner--dds--1.0--patch-2
>> 
>> 
>
> Yes, that does appear to be redundant.  I haven't seen or heard of the
> self-recursion that it causes, though.
>
> Regards,
>
> -- 
> Jim Ottaway

-- 
  David D. Smith

Attachment: pgpJAAKP1GDVX.pgp
Description: PGP signature

_______________________________________________
Planner-el-discuss mailing list
[email protected]
https://mail.gna.org/listinfo/planner-el-discuss

Reply via email to