----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/186/#review191 -----------------------------------------------------------
Ship it! i like it much better with the box on top.. nice work. now i suppose i'll need to add checkboxes to the time zone widget ;) - Aaron On 2008-09-10 14:27:35, Rafa? Mi?ecki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/186/ > ----------------------------------------------------------- > > (Updated 2008-09-10 14:27:35) > > > Review request for Plasma. > > > Summary > ------- > > Today we agreed with Aaron and Anne-Marie that we need some cleaning in time > zone(s) selection (specially choices including local time zone). > My idea is to remove "Use local time zone", keep KTimeZoneWidget and > QComboBox always enabled and put "Local" at top of QComboBox (no matter what > is selected in KTimeZoneWidget). If user additionaly selects some other time > zones in KTimeZoneWidget, then theses time zones are avaiable to choose in > "Default clocks to" (QComboBox). Of course "Local" is then available as well. > What do you think about such a solution? > > > EDIT: > > ----- > > <aseigo> Zajec: as for the ui, i'd put the combobox on the top now .. so that > it communicates clearly to the user that they don't need to select something > from the listing > > I added next mockup with this suggestion applied. > > ----- > > From: Celeste Lyn Paul > Date: 2008/9/10 > Subject: Re: Review Request: [MOCKUP] Clock: remove "Use local time zone" > To: plasma-devel@kde.org > > Checkboxes are much easier and intuitive for making multiple selections than > the current selection method. As it is, theres no way to know you can make > multiple selections. Checkboxes provide that "multi" affordance. > > I guess this is comment about whole KTimeZoneWidget? If so it doesn't really > have anything to this idea. However this may be worth of discussion. Maybe > you could open some bug report to discuss this? > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/clockapplet.cpp > > /trunk/KDE/kdebase/workspace/plasma/applets/libplasmaclock/timezonesConfig.ui > > Diff: http://reviewboard.vidsolbach.de/r/186/diff > > > Testing > ------- > > > Screenshots > ----------- > > New version of configuration dialog > http://reviewboard.vidsolbach.de/r/186/s/60/ > Next version of mockup > http://reviewboard.vidsolbach.de/r/186/s/61/ > > > Thanks, > > Rafa? > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
