On Tuesday 30 September 2008, Petri Damstén wrote: > On Tuesday 30 September 2008 14:36:10 Marco Martin wrote: > > > i'll take a look (perhaps it's a quick fix), because it's a really nice > > > set of applets, would be really cool to have them in 4.2 > > > > temperature works again > > http://reviewboard.vidsolbach.de/r/207/ > > Petri, ok to commit? > > propably dataEngine("sytemmonitor") -> dataEngine("systemmonitor") > otherwise ok. whoops, ahahah :) > > also, if you agree i have just a couple of suggestions/issue on what > > should be changed and then i think it could go in addons (heck, could > > even do them myself if it's ok) > > Of course it's ok :-) system monitor (applet) needs soliddevice, sensors, > executable & systemmonitor data engines. Now that you ported sensors to > systemmonitor and executable is going to kdebase there is only > systemmonitor in playground. Is it ready to be moved to kdeplasma-addons? actually i didn't look much at the code of the data engine, just tried to make some random queries with plasmaengineexplorer and seems to work well
btw i have just some issues at the applet side: system-monitor.cpp: shouldn't be a containment, since containments in containments aren't supported (Containment::loadApplet was disabled when the containment is an applet) i just fixed the loading by using Plasma::Applet::load() instead, but i think should really be just an applet. CPU: maybe an analog meter also here? Hardware-info: barely readable, just use textcolor from plasma theme maybe? Network: put also a label that shows in and out kbps? just a plot without numbers doesn't exactly say how much is fast :) i would also use the standard meter svgs from the plasma theme instead of custom one. the linear meter is exactly the same already, the analog meter i would just replace the one in plasma (that is reeeally old) with this one that works better at little sizes oh and last thing replace Header with Plasma::Frame so it will have a coherent look with other things and use a svg instead of hardcoded gradients Cheers, Marco Martin > > Petri _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel