On Friday 10 October 2008, Guillaume Pothier wrote: > http://pastebin.ca/1225015 (kdebase) > http://pastebin.ca/1225017 (playground/base)
things that jump out at me: Cosistency with the rest of KDE libs: * the "kephal" namespace shoulde be "Kephal" * instance() should be self() Questions; * why is "kephal::Screens::instance()->screens().size()" used sometimes and "kdephal::ScreenUtils::numScreens()" used instead? * why does DesktopCorona now have a m_numScreens member instead of just tracking whatever kephal says it is as the moment? * i suppose that PlasmaApp::screenMoved would need to move the associated view so it is still on screen? * with the code to manage the containments in DesktopCorona, we can probably just remove the containment size related code in DesktopView. PlasmaApp can manage just the View geometries and DesktopCorona just the containment geometries? it's a little muddled right now due to how things evolved over time. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
