On Monday 03 November 2008 17:58, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/254/ > ----------------------------------------------------------- > > Review request for Plasma. > > > Summary > ------- > > this makes the taskbar group menu to draw mostly like an extender, to > implement a mockup of the new theme > it's just a subclass of the menu with custom painting, still think in the > future should be the real tasks widgets within a view, but i kinda feel it's > a 4.3 thing :)
With the text color hardcoded to white, this code will only work with dark themes. I also don't think it's a good idea to abuse the tasks-hover background for the highlighted item, since this imposes a significant design limitation on the theme in that the taskbar button background has to be drawn in such a way that it also works as the highlighted menu background. I think the theme should provide a separate element for highlighted menu items. Looking at other systems it seems that Vista uses the same theme element for selected icons, items in treeviews, and popup menus. Fredrik _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
