----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/301/#review289 -----------------------------------------------------------
Ship it! it's not crude, it's pretty much how other fixed ratio applets work in the panel - Marco On 2008-12-12 07:18:14, Tony Murray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/301/ > ----------------------------------------------------------- > > (Updated 2008-12-12 07:18:14) > > > Review request for Plasma. > > > Summary > ------- > > This is a crude fix, but it is fairly minimal. I'm not sure how correct it > is. > > Issues still remain including: the buttons being smaller than they could be, > it is hard coded for two buttons on the panel, and assuming that the buttons > are square, but these two issues will not be issues with the current code and > can be addressed as needed in the future. > > Also, I would like to add a tooltip with the current track information, but > that would be a different patch and takes more knowledge of the applet API > than I currently have ;) > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.cpp > > Diff: http://reviewboard.vidsolbach.de/r/301/diff > > > Testing > ------- > > Just on my local machine. At least it doesn't cause a loop like using resize > in constraintsEvent() does ;) > > > Thanks, > > Tony > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
