> On 2008-12-14 09:10:47, Alex Merry wrote: > > /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.cpp, lines 280-294 > > <http://reviewboard.vidsolbach.de/r/309/diff/2/?file=1627#file1627line280> > > > > What happens if you Feeling Good by Michael Bublé playing, then the > > next song is Muse's cover of the same track?
Changed to: if ((metadata["Title"] != m_title) || (metadata["Artist"] != m_artist)) > On 2008-12-14 09:10:47, Alex Merry wrote: > > /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.cpp, line 304 > > <http://reviewboard.vidsolbach.de/r/309/diff/2/?file=1627#file1627line304> > > > > How is "@info:tooltip" a useful comment? > > > > Translators need to know what on earth "by" means in this context. > > > > How about "song artist, displayed below the song title"? Changed, still checking to see if I should remove the string till 4.3 - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/309/#review296 ----------------------------------------------------------- On 2008-12-14 09:52:34, Tony Murray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/309/ > ----------------------------------------------------------- > > (Updated 2008-12-14 09:52:34) > > > Review request for Plasma and Alex Merry. > > > Summary > ------- > > This adds a tooltip when on the panel. It includes artwork and track title > and artist. It does add one string, so we would have to clear that with > translators if we add it now "by %1". > > It does not update the tooltip while it is show, but the timeout is rather > short so it might not be worth the extra cpu cycles. > > QPixmap.scale handles null pixmaps gracefully, so it isn't necessary to have > a check for that right? > > Also, should this be 4.2 or 4.3? > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.h > /trunk/KDE/kdeplasma-addons/applets/nowplaying/nowplaying.cpp > > Diff: http://reviewboard.vidsolbach.de/r/309/diff > > > Testing > ------- > > On my local svn machine only. Vertical, Horizontal, and Planar all tested. > (It isn't supposed to show for Planar ;) > > > Thanks, > > Tony > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
