----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/325/#review314 -----------------------------------------------------------
Ship it! /trunk/KDE/kdelibs/plasma/applet.cpp <http://reviewboard.vidsolbach.de/r/325/#comment257> can you add a comment here noting what is going on in here? it's clearly written once you know what it is supposed to be doing ;) /trunk/KDE/kdelibs/plasma/applet.cpp <http://reviewboard.vidsolbach.de/r/325/#comment258> spaces around the +</horrible_nitpick> - Aaron On 2009-01-13 11:49:21, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/325/ > ----------------------------------------------------------- > > (Updated 2009-01-13 11:49:21) > > > Review request for Plasma. > > > Summary > ------- > > since it's 4.3 time... > This adds a new characteristic to plasma themes, an overalay image (in the > air theme in playground is used to to a watermark like effect, but is quite > flexible) > it uses some things: > alphaMask() a pixmap used to retrieve the alpha, can be the panel itself or > another one with the mask- prefix > > prefix-overlay is an image that will be drawn (with the transparency of > alphaMask()) with the following behaviour depending on hints: > never scaled, position 0,0 > never scaled, position depending on applet name (eeeh, code for this is not > overly pretty and probably can't be, i know :/) > tiled > scaled > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/applet.h > /trunk/KDE/kdelibs/plasma/applet.cpp > /trunk/KDE/kdelibs/plasma/framesvg.h > /trunk/KDE/kdelibs/plasma/framesvg.cpp > /trunk/KDE/kdelibs/plasma/private/framesvg_p.h > > Diff: http://reviewboard.vidsolbach.de/r/325/diff > > > Testing > ------- > > > Screenshots > ----------- > > > http://reviewboard.vidsolbach.de/r/325/s/98/ > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
