----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/335/#review328 -----------------------------------------------------------
Ship it! Thanks for having a look into it. (I've not tested it yet.) /trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.cpp <http://reviewboard.vidsolbach.de/r/335/#comment275> We're assuming here that X11 == XFree86, which might not be true on all platforms. (Mixing up protocol and implementation). I've asked Ade to have a look, it's not that I can come up with this myself. ;-) - Sebastian On 2009-01-18 12:22:12, Matt Rogers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/335/ > ----------------------------------------------------------- > > (Updated 2009-01-18 12:22:12) > > > Review request for Plasma. > > > Summary > ------- > > This patch adds support for laptop brightness keys on X11. Qt doesn't support > these keys yet, so this has to be implemented in a platform specific way and > I have provided support for them on X11. > > There is no OSD or other indication that the keys work other than the change > in brightness. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/battery/CMakeLists.txt > /trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.h > /trunk/KDE/kdebase/workspace/plasma/applets/battery/battery.cpp > > Diff: http://reviewboard.vidsolbach.de/r/335/diff > > > Testing > ------- > > compiled, installed, and verified the keys do work. > > > Thanks, > > Matt > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel