----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/122/#review155 -----------------------------------------------------------
Ship it! let's give it a whirl in trunk! :) - Aaron On 2009-02-18 11:10:25, Christian Mollekopf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/122/ > ----------------------------------------------------------- > > (Updated 2009-02-18 11:10:25) > > > Review request for Plasma, Aaron Seigo and Marco Martin. > > > Summary > ------- > > Since the gridlayout got fixed in qt 4.5 it's not anymore necessary to > recreate the layout every time. > Therefore this patch turns the LayoutWidget into a QGraphicsGridLayout (which > was my original intetion). > This should make it also easier to implement the popup with real items > instead of the current implementation. > I'm actually not sure if the call to LayoutWidget::layoutItems from the > TaskGroupItem is the perfect solution but it's necessary because the rows are > not recalculated otherwise. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.h 927988 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp 927988 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 927988 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 927988 > > Diff: http://reviewboard.kde.org/r/122/diff > > > Testing > ------- > > Tested locally, no backdrafts found > > > Thanks, > > Christian > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel