----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/101/#review159 -----------------------------------------------------------
it's an interesting hint as to the problem, but the code is in completely the wrong place. this fix needs to be in Containment, not a specific View subclass. - Aaron On 2009-02-16 02:16:03, Josh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/101/ > ----------------------------------------------------------- > > (Updated 2009-02-16 02:16:03) > > > Review request for Plasma. > > > Summary > ------- > > This patch fixes the bug 176280 where resizing a horizontal panel to be > larger would break the desktop. It applies to > kdebase/workspace/plasma/shells/desktop/panelview.cpp. What appears to be > the problem is at times panels will begin to bleed over into positive > coordinates (they are meant to be in negative coordinates). A function is > added to check for this overflow and fixes it by setting the y position to be > -(height_of_panel + 10). This is a collaboration of a few people and is > basically just a hack that has worked on 3 separate machines. It should help > to have more knowledgeable eyes check over it and maybe provide a better way > of solving the problem. Thanks for your time. > > > This addresses bug 176280. > https://bugs.kde.org/show_bug.cgi?id=176280 > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/shells/desktop/panelview.cpp 925267 > > Diff: http://reviewboard.kde.org/r/101/diff > > > Testing > ------- > > Tested with one panel, top and bottom. Tested with 2 panels, resizing both. > > > Thanks, > > Josh > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel