----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/145/#review218 -----------------------------------------------------------
/trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp <http://reviewboard.kde.org/r/145/#comment124> i'm not sure MinimumExpanding is really the right value here; probably just Expanding since it's supposed to take up as much room as possible. /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp <http://reviewboard.kde.org/r/145/#comment122> the linear layout is going to be leaking here. newLayout will be deleted by the Applet due to having setLayout called on it, but the linearLayout should be given a parent. /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp <http://reviewboard.kde.org/r/145/#comment123> you probably want to add some stretch to the first (0) column, otherwise with column 1 sitting there empty it'll get equal space. column 0 should have the biggest stretch weight. - Aaron On 2009-02-21 08:47:25, Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/145/ > ----------------------------------------------------------- > > (Updated 2009-02-21 08:47:25) > > > Review request for Plasma. > > > Summary > ------- > > I am trying to use the Plasma Widgets in the comic applet instead of painting > everything. After several failed tries I beg you for help. > > The version you see here is one of my early attempts -- so not really cleaned > up -- without features I implemented later, like having the scrollbars inside > the ImageWidget. That way the diff is a little smaller. > There is a problem though: If I choose to display the comics _not_ at their > original size it does not work as it should. > > Can someone give me a hint here? > > PS.: I'm not that experienced with Qt, so the problem might be trivial for > you to find. > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/comic/CMakeLists.txt 924313 > /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 924382 > /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 924726 > /trunk/KDE/kdeplasma-addons/applets/comic/imagewidget.h PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/comic/imagewidget.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/145/diff > > > Testing > ------- > > Works more or less when "Actual Size" is ticked, but not if that is _not_ the > case see screenshot. > > > Screenshots > ----------- > > "Actual Size" not ticked > http://reviewboard.kde.org/r/145/s/24/ > > > Thanks, > > Matthias > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
