----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/483/#review744 -----------------------------------------------------------
a few minor things, but the patch looks good in general :) trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h <http://reviewboard.kde.org/r/483/#comment444> nitpick: no space after the * :) trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/483/#comment447> !m_paste trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/483/#comment445> please use ! instead of 'not' trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/483/#comment448> !m_bottomSeparator trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp <http://reviewboard.kde.org/r/483/#comment446> is the bottom separator really necessary? one should be provided by the caller of this method if it is... - Aaron On 2009-03-30 12:35:21, Danilo Cesar Lemes de Paula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/483/ > ----------------------------------------------------------- > > (Updated 2009-03-30 12:35:21) > > > Review request for Plasma. > > > Summary > ------- > > Adding history to pastebin plasmoid. > > Plasmoid should show the last 3 links shown by the plasmoid (when you click > with the right button), and it should be copied to clipboard when user click > on it. > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 945384 > trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 945384 > > Diff: http://reviewboard.kde.org/r/483/diff > > > Testing > ------- > > > > > Thanks, > > Danilo Cesar > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel