hi ... can people, esp those with slideshows for wallpapers, try this patch again kdelibs/plasma/ and report if you have any problems with it in practice.
it's 2:22am here so this could be wildly incorrect ;) but i don't see the point of keeping the thread (and it's allocations?) hanging around indefinitely. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software
Index: private/wallpaperrenderthread.cpp
===================================================================
--- private/wallpaperrenderthread.cpp (revision 956399)
+++ private/wallpaperrenderthread.cpp (working copy)
@@ -117,7 +117,7 @@
if (file.isEmpty() || !QFile::exists(file)) {
emit done(token, result, file, size, method, color);
- continue;
+ break;
}
QPoint pos(0, 0);
@@ -251,7 +251,7 @@
for (int y = pos.y(); y < size.height(); y += scaledSize.height()) {
p.drawImage(QPoint(x, y), img);
if (m_restart) {
- goto endLoop;
+ continue;
}
}
}
@@ -262,7 +262,6 @@
// signal we're done
emit done(token, result, file, size, method, color);
- endLoop: continue;
}
}
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
