----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/671/ -----------------------------------------------------------
(Updated 2009-05-04 13:10:36.344756) Review request for Plasma. Changes ------- Good points Aaron, now waking is done every minute, and only when there are new completed jobs. timerEvent of Applet is called, and this diff also contains a chance that shows the amount of completed jobs in the completed jobs group title. Summary ------- As an experiment, I'd tried this possible approach to the issue that (< wow, review board is * too * smart :p) we probably want the completed jobs to get automatically destroyed, as discussed in the Systray Jobs mailing list discussion. The current timeout time is a bit arbitrary (5 minutes), but works pretty well imo. The nice thing here is we don't start the timeout until the computer is actually being used, so if you go away from your computer to make some nice delicious meal (hmm, maybe a nice curry?), and a job completes in the meantime, it will still show after you get back behind your computer. I think this behavior is quite nice, but let me know what you think, and if you think we should use a different timeout time. But be quick, feature freeze is today :p Diffs (updated) ----- /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/CMakeLists.txt 963164 /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/config.h.in PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.h 963164 /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 963165 /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/extendertask.cpp 963164 Diff: http://reviewboard.kde.org/r/671/diff Testing ------- Thanks, Rob _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
