-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/675/#review1078
-----------------------------------------------------------

Ship it!


Looks good to me... this is indeed much less 'stressfull'. I was wondering 
though: wouldn't it make sense to use a an enabled info icon in case there are 
only notifications and/or completed jobs? Still paint the number in front of 
it, but don't use a stopped spinner, but the I icon when no jobs are running.

- Rob


On 2009-05-06 08:14:43, Aaron Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/675/
> -----------------------------------------------------------
> 
> (Updated 2009-05-06 08:14:43)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Make the ExtenderTask, responsible for showing job/notification status always 
> visible so that it isn't jostling items around in the tray as it comes and 
> goes.
> 
> Perhaps unrelated, there's a "gap" between the unhide icon and the first 
> entry in the tray which is rather unsightly. not sure where that's coming 
> from ....
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/taskarea.h 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/taskarea.cpp 
> 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/extendertask.h 
> 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/extendertask.cpp 
> 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.h 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 964316 
> 
> Diff: http://reviewboard.kde.org/r/675/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aaron
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to