----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/689/ -----------------------------------------------------------
Review request for Plasma. Summary ------- Reposting patch for multiple actions support for the Nepomuk search runner. It adds open with and service menu actions to the nepomuk search runner. Now uses the new KFileItemActions and KFileItemListProperties and no longer depends on libkonq. Minor style issue: the two new classes in KIO don't have camel case includes yet, and I wasn't sure if I should add them myself. Another possible point for improvement: move the parseMenu method to AbstractRunner as something like an addActionsFromMenu method to reuse code between runners (useful for the locations runner and the window management runner which I'm thinking of moving into kdereview) Diffs ----- /trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.h 967101 /trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.cpp 967101 /trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop 967101 /trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/queryclientwrapper.cpp 967101 Diff: http://reviewboard.kde.org/r/689/diff Testing ------- Thanks, Ryan _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
