----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/889/#review1383 -----------------------------------------------------------
how about just doing it from the engine itself, keeping this all in one place and avoiding synchronization issues? i'll upload a patch in a moment. - Aaron On 2009-06-25 13:54:58, Jacopo De Simoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/889/ > ----------------------------------------------------------- > > (Updated 2009-06-25 13:54:58) > > > Review request for Plasma. > > > Summary > ------- > > The plasma timeengine reacts to timezone changes, but the timesource does > not; this patch filles the gap. > > note the signal/slot/bool/updateslot dance is due to the fact that timesource > could possibly get the update signal before KSystemTimeZone (and indeed it > does) > > > This addresses bugs not and reported?. > https://bugs.kde.org/show_bug.cgi?id=not > https://bugs.kde.org/show_bug.cgi?id=reported? > > > Diffs > ----- > > branches/KDE/4.3/kdebase/workspace/plasma/dataengines/time/timesource.h > 987201 > branches/KDE/4.3/kdebase/workspace/plasma/dataengines/time/timesource.cpp > 987201 > > Diff: http://reviewboard.kde.org/r/889/diff > > > Testing > ------- > > Basic testing done and it works > > > Thanks, > > Jacopo > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel