----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/#review1760 -----------------------------------------------------------
does this really belong in AbstractRunner? obviously, it's runners that are currently using it, but this method doesn't actually have anything to do with the functionality AbstractRunner provides. maybe it should be added to plasma.h instead? trunk/KDE/kdelibs/plasma/abstractrunner.cpp <http://reviewboard.kde.org/r/1115/#comment1148> this should probably have a Q_ASSERT(menu) just to be safe - Aaron On 2009-07-25 01:24:26, Ryan Bitanga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1115/ > ----------------------------------------------------------- > > (Updated 2009-07-25 01:24:26) > > > Review request for Plasma. > > > Summary > ------- > > This adds a convenience method to AbstractRunner to extract a list of actions > from a QMenu. Hierarchy is preserved by prefixing submenu text to the actions > in the submenus. > > Current uses are extracting actions from KFileItemActions and libtaskmanager. > The code is currently used by the window management runner in playground, the > multiple action nepomuk search runner patch in reviewboard, and fsrunner in > kde-apps.org. This method will help avoid code duplication in these runners > as well as future runners that can extract info from menus. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/abstractrunner.h 1001909 > trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1001909 > > Diff: http://reviewboard.kde.org/r/1115/diff > > > Testing > ------- > > > Thanks, > > Ryan > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
