----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1220/#review1885 -----------------------------------------------------------
Ship it! looks fine; perhaps all the instances of -1 should be replaced with a `static const int UNLIMITED_ICONS = -1` in the header file? :) - Aaron On 2009-08-02 23:33:23, Shafqat Bhuiyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1220/ > ----------------------------------------------------------- > > (Updated 2009-08-02 23:33:23) > > > Review request for Plasma. > > > Summary > ------- > > This patch fixes a couple of bugs when having unlimited visible icons in the > quicklaunch plasmoid. > They were: > > - Having a vertical panel with unlimited number of icons resulted in just one > row of squashed icons > > - Having unlimited icons gives a bigger width for no reason > > This should be backported to 4.3 > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp > 1004927 > > Diff: http://reviewboard.kde.org/r/1220/diff > > > Testing > ------- > > tested and compiled on trunk > > > Thanks, > > Shafqat > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel