> On 2009-08-10 06:41:57, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, > > line 43 > > <http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line43> > > > > 42 + 13?
This is taken from Imageshack backend, strange notation indeed. ;-) > On 2009-08-10 06:41:57, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp, line 101 > > <http://reviewboard.kde.org/r/1251/diff/1/?file=9804#file9804line101> > > > > why are all these image server classes being cast to themselves? This is also question to applet developer, I can later create patch that fixes thinks like that and also adds possibility to show error message (at least this backend can show different error messages, API returns codes). - Michal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1948 ----------------------------------------------------------- On 2009-08-09 21:08:23, Michal Dutkiewicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1251/ > ----------------------------------------------------------- > > (Updated 2009-08-09 21:08:23) > > > Review request for Plasma. > > > Summary > ------- > > This patch adds support for Simplest Image Hosting > (http://simplest-image-hosting.net/) to pastebin applet. > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h > PRE-CREATION > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp > PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui > 1008396 > > Diff: http://reviewboard.kde.org/r/1251/diff > > > Testing > ------- > > Works fine except showing error icon even if upload is successful (there is > success notification and link is added to history). > > > Thanks, > > Michal > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
