On Wed, Aug 12, 2009 at 6:11 PM, Sebastian Kügler<se...@kde.org> wrote: > On Wednesday 12 August 2009 20:21:16 Darío Andrés wrote: >> 2009/8/12 Darío Andrés <andresbajotie...@gmail.com>: >> > * Issue 1: >> > >> > In Frame, when a URL is not passed to the widget constructor it >> > creates an empty KUrl for "m_currentUrl" and that determines the frame >> > will use the "Default" image until a custom image url is set. >> > However, in the code, there are checks for "KUrl("Default")" which in >> > fact isn't there; so an empty(default) image is not detected; and this >> > causes some bugs (as: the "Open Image" menu option is shown and >> > enabled; and when it is clicked it fails as it tries to run KRun(empty >> > KUrl); >> > >> > Proposed fix: >> > Use KUrl() (empty) and KUrl::isEmpty to check for the Default image >> > (see attached patch) >> >> I forgot to attach the patch... > > Patch looks sane, please commit :) > -- > sebas
Commited: svn rev. 1010591 (in branch4.3 all the checks and the initialization uses KUrl("Desktop")) Have you looked into the second issue ? Thanks! > > http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel