----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1303/#review2017 -----------------------------------------------------------
Ship it! +1, this is actually a thing i was procrastinating to do :) not sure a kwin theme is the way to go but since fow now it's the way used this patch should go in for sure - Marco On 2009-08-13 00:02:57, Roderick Greening wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1303/ > ----------------------------------------------------------- > > (Updated 2009-08-13 00:02:57) > > > Review request for Plasma and Artur de Souza (MoRpHeUz). > > > Summary > ------- > > As plasma-netbook was transitioned from being called MID to Netbook, not all > things were updated to account for this. Specifically, in this case, was the > minimal kwin window decorations for use in plasma-netbook. > > This patch updates the references to names, files, namespaces and classes to > Netbook (from Mid). > > > Diffs > ----- > > trunk/playground/base/plasma/netbook/kwin/CMakeLists.txt 1010511 > trunk/playground/base/plasma/netbook/kwin/mid/CMakeLists.txt 1010511 > trunk/playground/base/plasma/netbook/kwin/mid/mid.cpp 1010511 > trunk/playground/base/plasma/netbook/kwin/mid/mid.desktop 1010511 > trunk/playground/base/plasma/netbook/kwin/mid/mid.h 1010511 > trunk/playground/base/plasma/netbook/kwin/netbook/CMakeLists.txt > PRE-CREATION > trunk/playground/base/plasma/netbook/kwin/netbook/netbook.desktop > PRE-CREATION > trunk/playground/base/plasma/netbook/kwin/netbook/netbook.h PRE-CREATION > trunk/playground/base/plasma/netbook/kwin/netbook/netbook.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1303/diff > > > Testing > ------- > > The patch is a fairly simple one, only updating the names to the correct new > naming scheme. Builds and compiles as it previously did. > > Unfortunately, the window decoration is still broken, and does not load, > which is the same behaviour exhibited when the plugin was called > kwin3_mid.so. I expect there is some other issue preventing it from loading > properly. > > This patch is still necessary to move forward with the naming change. > > > Thanks, > > Roderick > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
