On Wed, Aug 19, 2009 at 4:43 PM, Aaron J. Seigo<ase...@kde.org> wrote: > On Wednesday 05 August 2009, Richard Dale wrote: >> It also moves a few things around in applet.cpp, so that the code for >> shortcuts is all in Applet::addGlobalShortcutsPage() including the >> connect() calls to the configDialogFinished() slot to handle >> completing the dialog. > > instead of addGlobalShortcutsPage(KConfigDialog*), it probably makes more > sense to have a "addStandardConfigurationPages(KConfigDialog*)" as that's more > generic. > > it would be really nice to be able to avoid that altogether, though, perhaps > with a custom subclass of KConfigDialog* that has some magic behaviour in it. > but seeing as this will be used for a handful of classes (JavaScript, Ruby, > Python and C# applet script engines, plus what ever else happens along in the > future) it's probably not worth it. > > if you can change the name of the method in your patch, please commit. OK, I've commited the patch. But I have one question, in generateGenericConfigDialog() a nullManager is created to delete the dialog.
KConfigSkeleton *nullManager = new KConfigSkeleton(0); KConfigDialog *dialog = new KConfigDialog(0, configDialogId(), nullManager); ... QObject::connect(dialog, SIGNAL(finished()), nullManager, SLOT(deleteLater())); But when a dialog is created for a configLoader a nullManager isn't created. Does that mean that a dialog created like this tidies itself? new KConfigDialog(0, d->configDialogId(), d->configLoader); -- Richard _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
