----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/680/#review2132 -----------------------------------------------------------
Ship it! - Aaron On 2009-08-24 07:56:57, Petri Damstén wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/680/ > ----------------------------------------------------------- > > (Updated 2009-08-24 07:56:57) > > > Review request for Plasma. > > > Summary > ------- > > Moonrise/set patch using new TimeSource in time dataengine. This also changes > all sun and moon phase calculation code so same code can be used for all the > calculations. This is too late for 4.3, but I'll post it here so it won't get > lost. > > > Diffs > ----- > > /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarposition.cpp > 1014903 > /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarposition.h > 1014903 > /trunk/KDE/kdebase/workspace/plasma/dataengines/time/phases.cpp 1014903 > /trunk/KDE/kdebase/workspace/plasma/dataengines/time/CMakeLists.txt 1014903 > /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarsystem.h > PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarsystem.cpp > PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/dataengines/time/time_solar_export.h > 1014903 > /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.h 1014903 > /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.cpp 1014903 > /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/CMakeLists.txt > 1014903 > > /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/dataengineconsumer.h > PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_bbcukmet.h > 1014903 > > /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_bbcukmet.cpp > 1014903 > /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_envcan.h > 1014903 > /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_envcan.cpp > 1014903 > > Diff: http://reviewboard.kde.org/r/680/diff > > > Testing > ------- > > > Thanks, > > Petri > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
