-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1526/#review2247
-----------------------------------------------------------


this results in a "leak" in that every window ever created will have an item 
that stays forever, no? shouldn't it only keep track of winIds that still 
exist, and do so in the manual grouping strategy?

- Aaron


On 2009-09-04 19:48:58, Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1526/
> -----------------------------------------------------------
> 
> (Updated 2009-09-04 19:48:58)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> this fixes the manual sorting strategy, which is broken atm if the desktop is 
> changed.
> 
> Since the manual sorting strategy relies on AbstractGroupableItem pointer not 
> to change, we cannot remove it from the bookkeeping in case it returns (after 
> a desktop change for instance).
> I don't know if this is acceptable because this results in the item never 
> being removed from the itemList until the groupmanager instance is deleted 
> (lifetime of the applet which created the instance).
> 
> Another option would be to identify tasks and groups by WId, which is a bit 
> more complicated, but if you think it would be better/cleaner, i could supply 
> a patch.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1018615 
> 
> Diff: http://reviewboard.kde.org/r/1526/diff
> 
> 
> Testing
> -------
> 
> Tried it, works.
> 
> 
> Thanks,
> 
> Christian
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to