-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1606/
-----------------------------------------------------------
(Updated 2009-09-15 21:12:44.133738)
Review request for Plasma.
Changes
-------
goes trough AssociatedApplicationManager singleton
Summary
-------
first implementation of an idea discussed @tokamak: add api to assign the
execution of something to an applet. the rationale is to launch an app that is
the "full version" of that applet, where the applet serves as little preview.
it is possible to assign a kservice (usually used with
kservice::servicefromdesktopfile("app name")) and an optional argument.
if the service is missing and the argument url is present the url will be
opened based on its mimetype.
an applethandle icon and a context menu entry will be added to launch that
external tool
now there are roe rough edges:
-api: pass kservice and url or just strings to make bindings easier?
-urls: right now there is only one parameter: maybe having support for a list?
-naming: now all the names are talking about an "external tool", the applet
handle uses the "maximize" icon, calling it maximize everywhere? i would leave
external tool in the api and call maximize the action and the action text, that
is what is presented to the user..
Diffs (updated)
-----
/trunk/KDE/kdelibs/plasma/private/associatedapplicationmanager_p.h
PRE-CREATION
/trunk/KDE/kdelibs/plasma/private/associatedapplicationmanager.cpp
PRE-CREATION
/trunk/KDE/kdelibs/plasma/private/applethandle_p.h 1023331
/trunk/KDE/kdelibs/plasma/containment.cpp 1023331
/trunk/KDE/kdelibs/plasma/private/applet_p.h 1023331
/trunk/KDE/kdelibs/plasma/private/applethandle.cpp 1023331
/trunk/KDE/kdelibs/plasma/CMakeLists.txt 1023331
/trunk/KDE/kdelibs/plasma/applet.h 1023331
/trunk/KDE/kdelibs/plasma/applet.cpp 1023331
Diff: http://reviewboard.kde.org/r/1606/diff
Testing
-------
Thanks,
Marco
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
