> On 2009-08-28 21:42:20, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/corona.cpp, line 511 > > <http://reviewboard.kde.org/r/1428/diff/1/?file=10799#file10799line511> > > > > i thought we were going to avoid the bool and instead use Qt::Alignment? > > wrote: > So only one public method with optional Alignment flag (by default > alignment would be as now, usually to left edge etc.) and for now accepting > only Qt::AlignCenter?
what concerns me is to have a function that accepts all the possible alignment flags and will totally ignore things as alignTop, just because in public api would be a bit meh.. what about make a distiction between horizontal and vertical?, i'm not really sure about a possible use case for AlignLeft|AlignVCenter tough... - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1428/#review2173 ----------------------------------------------------------- On 2009-09-27 13:18:54, Michal Dutkiewicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1428/ > ----------------------------------------------------------- > > (Updated 2009-09-27 13:18:54) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > This patch aims to provide centered tool tips for Plasma (aligned to edge in > some cases looks bad) and ability to set pop ups alignment (by default it > uses left alignment for compatibility). > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/applet.h 1028190 > /trunk/KDE/kdelibs/plasma/applet.cpp 1028190 > /trunk/KDE/kdelibs/plasma/corona.h 1028190 > /trunk/KDE/kdelibs/plasma/corona.cpp 1028190 > /trunk/KDE/kdelibs/plasma/tooltipmanager.cpp 1028190 > > Diff: http://reviewboard.kde.org/r/1428/diff > > > Testing > ------- > > Tested for vertical and horizontal form factors and for floating applets. > > > Thanks, > > Michal > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
