----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1800/#review2572 -----------------------------------------------------------
great to see this code moving into Plasma::WindowEffects. (maybe we can convince a compiz'r to provide a compiz implementation of this as well... though common xatoms would be even better of course.) a few small comments; other than the enum vs string thing, it looks good to my eyes. /trunk/KDE/kdelibs/plasma/windoweffects.h <http://reviewboard.kde.org/r/1800/#comment1895> QString or an enumeration? an enum would give us compiler checking on spelling :) /trunk/KDE/kdelibs/plasma/windoweffects.cpp <http://reviewboard.kde.org/r/1800/#comment1896> this really feels like something that should be found in KWindowSystem; though i'm not sure if Seli would be cool with a convenience function only we are using? can't hurt to ask, anyways. - Aaron On 2009-10-06 21:10:44, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1800/ > ----------------------------------------------------------- > > (Updated 2009-10-06 21:10:44) > > > Review request for Plasma. > > > Summary > ------- > > this is the tiny part for the overview i had promised (that could or could > not be used, anyways..) > those are some functions in Plasma::WindowEffects to abstract away some of > the code to do the taskbar thumbnails, so it would be handy to use it also > from somewhere else without having to directly use X calls > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/private/windowpreview.cpp 1032016 > /trunk/KDE/kdelibs/plasma/private/windowpreview_p.h 1032016 > /trunk/KDE/kdelibs/plasma/windoweffects.h 1032016 > /trunk/KDE/kdelibs/plasma/windoweffects.cpp 1032016 > > Diff: http://reviewboard.kde.org/r/1800/diff > > > Testing > ------- > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
