----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1984/#review2833 -----------------------------------------------------------
a few questions about the API additions below; also, have you worked up any script plugins for this yet? /trunk/KDE/kdelibs/plasma/scripting/wallpaperscript.h <http://reviewboard.kde.org/r/1984/#comment2200> s,plasmoid,wallpaper :) /trunk/KDE/kdelibs/plasma/wallpaper.h <http://reviewboard.kde.org/r/1984/#comment2198> i don't think this is binary compatible; so i think that wallpaper scripts will likely need to be a subclass in this case. /trunk/KDE/kdelibs/plasma/wallpaper.h <http://reviewboard.kde.org/r/1984/#comment2199> should this be a Q_PRIVATE_SLOT? - Aaron On 2009-10-27 11:36:55, Petri Damstén wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1984/ > ----------------------------------------------------------- > > (Updated 2009-10-27 11:36:55) > > > Review request for Plasma. > > > Summary > ------- > > Adds WallpaperScript for scripted wallpaper plugins. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1040341 > /trunk/KDE/kdelibs/plasma/packagestructure.cpp 1040341 > /trunk/KDE/kdelibs/plasma/plasma.h 1040341 > /trunk/KDE/kdelibs/plasma/private/wallpaper_p.h 1040341 > /trunk/KDE/kdelibs/plasma/scripting/scriptengine.h 1040341 > /trunk/KDE/kdelibs/plasma/scripting/scriptengine.cpp 1040341 > /trunk/KDE/kdelibs/plasma/scripting/wallpaperscript.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/scripting/wallpaperscript.cpp PRE-CREATION > /trunk/KDE/kdelibs/plasma/wallpaper.h 1040341 > /trunk/KDE/kdelibs/plasma/wallpaper.cpp 1040341 > > Diff: http://reviewboard.kde.org/r/1984/diff > > > Testing > ------- > > > Thanks, > > Petri > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel