----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/#review2856 -----------------------------------------------------------
i generally like it, apart of the couple of code issues below i think the animation of the grid should be a bit "lighter", like all the items scrolling in the same direction like a single block, appearing from left (scrollwidget would have to always clip, but that's sensible) there seems to be some issues with size hints, since the only way to have a proper hint is to have the final size the widget will have seems hard to fix, how do you guys did with the real qt ones? trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h <http://reviewboard.kde.org/r/2008/#comment2228> QGraphicsLayoutItem should be more than enough trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h <http://reviewboard.kde.org/r/2008/#comment2229> just generic code style stuff: all this block should be indented a level less, so public: at the level of { - Marco On 2009-10-29 18:45:58, igorto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2008/ > ----------------------------------------------------------- > > (Updated 2009-10-29 18:45:58) > > > Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza > (MoRpHeUz), and Adenilson Cavalcanti. > > > Summary > ------- > > Add animated layouts to plasma-netbook. > Animate add/remove widgets in layouts(grid and linear). > > > Diffs > ----- > > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.cpp > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt > 1042281 > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.cpp > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.h > 1042281 > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp > 1042281 > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h > 1042281 > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp > 1042281 > trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/CMakeLists.txt > 1042281 > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.h > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/animatedgridlayout.cpp > PRE-CREATION > trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.h > 1042281 > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp > 1042281 > > Diff: http://reviewboard.kde.org/r/2008/diff > > > Testing > ------- > > > Thanks, > > igorto > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
