----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2099/#review2992 -----------------------------------------------------------
Ship it! looks fine; these kinds of bug fixes/improvements can usually just be committed directly to svn. you only really need to use r-b when it's something big and/or you are unsure about and would like other input on :) - Aaron On 2009-11-09 17:21:53, Jean-Baptiste Rouault wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2099/ > ----------------------------------------------------------- > > (Updated 2009-11-09 17:21:53) > > > Review request for Plasma. > > > Summary > ------- > > This patch makes the firefox bookmarks support in the bookmarks runner work > even if there is only one firefox profile. > It also iterates over the groups which actually exist in the profiles.ini > file to avoid unnecessary looping. > > > Diffs > ----- > > > trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp > 1046722 > > Diff: http://reviewboard.kde.org/r/2099/diff > > > Testing > ------- > > Tested with a profiles.ini containing only one profile, and another one > containing more than 2 profiles. > > > Thanks, > > Jean-Baptiste > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
