----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2451/#review3510 -----------------------------------------------------------
looks fine except line 286, i would really love to avoid that if somehow possible (probably by fixing the applt handle) svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp <http://reviewboard.kde.org/r/2451/#comment2809> are you sure this is needed? setting the textedit minimum size should already force the applet handle to not resize less than that since it sould change the size hint - Marco On 2009-12-26 15:37:29, Darío Andrés wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2451/ > ----------------------------------------------------------- > > (Updated 2009-12-26 15:37:29) > > > Review request for Plasma. > > > Summary > ------- > > To fix some resizing problems, we are forcing a minimum size using the layout > minimum size (this should be done automatically, but Plasma is failing > somewhere). > The patch also sets some margins, paddings, and a minimumSize for the text > edit > > Finally, it uses the Plasma::TextEdit::setNativeWidget() function to set the > custom text edit. > > > Diffs > ----- > > > svn://anonsvn.kde.org/home/kde/trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp > 1065942 > > Diff: http://reviewboard.kde.org/r/2451/diff > > > Testing > ------- > > Resizing problems dissapeared > > > Thanks, > > Darío > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
