----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2485/ -----------------------------------------------------------
Review request for Plasma. Summary ------- When a notification with actions is shown, clicking an action button causes the ActionInvoked (and NotificationClosed) signals to be emitted twice. See this bug report: https://bugs.edge.launchpad.net/ubuntu/+source/banshee/+bug/501677 It seems the QDBusAbstractAdaptor automatically forward signals, even if I find no evidence of this in the source code. Diffs ----- trunk/KDE/kdebase/workspace/plasma/generic/dataengines/notifications/notificationsengine.cpp 1065171 Diff: http://reviewboard.kde.org/r/2485/diff Testing ------- - Monitor the signals with: dbus-monitor "interface=org.freedesktop.Notifications,type=signal" - Start an application which show a notification with actions. I used the test-multi-actions.py example from python-notify. - Click an action, notice both signals are listed twice. - After the patch, signals are only listed once. Thanks, Aurélien _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
