----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2592/#review3718 -----------------------------------------------------------
Ship it! small name change to the signal, otherwise looks good. trunk/KDE/kdelibs/plasma/runnermanager.h <http://reviewboard.kde.org/r/2592/#comment3081> perhaps just "queryFinished()" - Aaron On 2010-01-14 15:19:20, igorto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2592/ > ----------------------------------------------------------- > > (Updated 2010-01-14 15:19:20) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > Right now when we use RunnerManager::launchQuery we do not know when the > query finish. Knowing it we can improve some animations. This patch add a new > signal called launchQueryFinished. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/runnermanager.h 1074622 > trunk/KDE/kdelibs/plasma/runnermanager.cpp 1074622 > > Diff: http://reviewboard.kde.org/r/2592/diff > > > Testing > ------- > > > Thanks, > > igorto > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
