----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2659/#review3783 -----------------------------------------------------------
The code looks good, but I'm slightly concerned about the usability aspect in that this works differently from type and search in Dolphin. There's also no visual feedback when the search is reset. I think it would be a good idea to get some input on this from our usability experts. trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp <http://reviewboard.kde.org/r/2659/#comment3205> There's no need to stop the timer here, since calling start() will restart it. - Fredrik On 2010-01-21 05:09:57, Shantanu Tushar Jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2659/ > ----------------------------------------------------------- > > (Updated 2010-01-21 05:09:57) > > > Review request for Plasma and Fredrik Höglund. > > > Summary > ------- > > This patch intends to provide a simple selection method to select icons. Its > intended to be able to select a file plasma-desktop.desktop by just typing > initial characters, "plas" for example. > Comments on the hard-coded 2000ms welcome. If the user doesn't press any key > within 2000ms after the last key press, the match string clears. > > > This addresses bug 187241. > https://bugs.kde.org/show_bug.cgi?id=187241 > > > Diffs > ----- > > trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 1077898 > trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1077898 > > Diff: http://reviewboard.kde.org/r/2659/diff > > > Testing > ------- > > Works with the latest trunk. > > > Thanks, > > Shantanu > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
