> On 2010-02-17 12:54:30, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/widgets/webview.cpp, line 174 > > <http://reviewboard.kde.org/r/2990/diff/1/?file=19582#file19582line174> > > > > thing that we were talking about the other day: > > are you sure nw that page() and mainFrame() are always valid?
yes, I've checked QtWebKit code and they are always valid. - Davide ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2990/#review4192 ----------------------------------------------------------- On 2010-02-17 02:46:46, Davide Bettio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2990/ > ----------------------------------------------------------- > > (Updated 2010-02-17 02:46:46) > > > Review request for Plasma. > > > Summary > ------- > > This patch replaces all the old code that uses directly KWebPage with new > code that uses KGraphicsWebView. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/widgets/webview.h 1090797 > /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1090803 > /trunk/KDE/kdelibs/plasma/private/animablegraphicswebview_p.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1090803 > /trunk/KDE/kdelibs/plasma/private/animablegraphicswebview.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/2990/diff > > > Testing > ------- > > > Thanks, > > Davide > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel