Hello,
After struggling to get my notebook fixed, I was studying code for the
networkmanager in kdereview/networkmanager . I have made a small fix which
displays "Wire Unplugged" when a wired network is Unavailable, kindly take a
look at the attached patch and comment (I wasn't sure if I should use the
reviewboard for this, please tell me if that is the case). I was also going
to fix the wrong disconnect problem, but it seems its already fixed now :)
Also, I've noticed that a dial-like meter is being used for the signal
strength along with the progress bar. IMO, the meter is very small to figure
out what value it displays, and anyway the progress bar is a better
candidate for displaying the strength, isn't it?
--
Shantanu Tushar (UTC +0530)
http://www.shantanutushar.com
Index: interfaceitem.cpp
===================================================================
--- interfaceitem.cpp (revision 1097548)
+++ interfaceitem.cpp (working copy)
@@ -254,6 +254,9 @@
switch (state) {
case Solid::Control::NetworkInterface::Unavailable:
+ if (m_iface->type() == Solid::Control::NetworkInterface::Ieee8023) {
+ lname = i18nc("wired interface network cable unplugged", "Cable Unplugged");
+ }
setEnabled(false);
break;
case Solid::Control::NetworkInterface::Disconnected:
@@ -269,7 +272,7 @@
break;
case Solid::Control::NetworkInterface::Activated:
if (connectionName().isEmpty()) {
- lname = i18nc("wireless interface is connected", "Connected");
+ lname = i18nc("wired interface is connected", "Connected");
} else {
lname = i18nc("wireless interface is connected", "Connected to %1", connectionName());
}
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
