filipf accepted this revision as: filipf.
filipf added a comment.
This revision is now accepted and ready to land.
Looks OK, along with these two inline comments I'd also add some reasoning
for the change to the commit message.
INLINE COMMENTS
> index.docbook:28
>
> -<para>This is a module to configure global options for the &plasma;
> workspace.
> +<para>This is a module to configure the general workspace behavior.
> </para>
I'd drop the "the"
> workspaceoptions.cpp:42
> QStringLiteral("1.1"),
> - i18n("System Settings module for
> managing global options for the Plasma Workspace."),
> + i18n("System Settings module for
> configuring the general workspace behavior."),
> KAboutLicense::GPL);
I'd drop the "the"
REPOSITORY
R119 Plasma Desktop
BRANCH
use-better-global-workspace-behavior-kcm-title-and-icon (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22871
To: GB_2, #plasma, #vdg, filipf
Cc: filipf, kde-doc-english, ngraham, #vdg, plasma-devel, #plasma, LeGast00n,
jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna,
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
