-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3165/
-----------------------------------------------------------
(Updated 2010-03-07 01:16:48.875540)
Review request for Plasma.
Changes
-------
describe unfixed and potentially new issuse
Summary
-------
The system tray behaves very erratically here, depending on exact circumstances
(compositing or not, some apparently random factors) so I looked into the code
a bit.
First I removed a very ugly hack that apparently fixed a bug that could be
fixed otherwise, this is why I'm posting this to reviewboard. That part is the
last hunk.
After doing that plasma-desktop crashed a lot, so I fixed the obviously
dangerous (the way non-POD statics are) to outright incorrect (deleting and
never recreating the background thingie) usage of class-statics, too.
This addresses bug 228655.
https://bugs.kde.org/show_bug.cgi?id=228655
Diffs
-----
trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/taskarea.cpp
1100150
Diff: http://reviewboard.kde.org/r/3165/diff
Testing (updated)
-------
Not much yet, about two hours of use - no crashes so far. No background
corruption.
Update: Two things are still strange:
- The Konversation icon usually has the same background as other icons, except
when it's flashing - then it temporarily gets the background of the notifier
(the 'i' in circle thingie). This might be new behavior with these patches.
- The Nepomuk indexer icon still auto-hides after a while (a few minutes) even
though configured to "Always Show". I've even seen it unhide for a fraction of
a second and then hide again while I was just typing a message in Konversation.
This behavior (except maybe the brief appearance) is not new.
Thanks,
Andreas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
