GB_2 added inline comments.

INLINE COMMENTS

> broulik wrote in SidebarMode.cpp:570
> Not a huge fan of this.
> Can this be done in qqc2-desktop-style to be generic and fix every `Menu` and 
> `ComboBox` popup?

Not really, seems like the KQuickStyleItem only has access to the QML window of 
the menu control and also can't detect events on the rest of the QWidget window 
:(

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to